Skip to content

[VarDumper] Add SymfonyCaster::castRequest() #20881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2016

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Dec 12, 2016

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Because these properties are lazily initialized.


class SymfonyCaster
{
private static $getters = array(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be $requestGetters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@fabpot
Copy link
Member

fabpot commented Dec 13, 2016

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 61cce2a into symfony:master Dec 13, 2016
fabpot added a commit that referenced this pull request Dec 13, 2016
…grekas)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[VarDumper] Add SymfonyCaster::castRequest()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Because these properties are lazily initialized.

Commits
-------

61cce2a [VarDumper] Add SymfonyCaster::castRequest()
@nicolas-grekas nicolas-grekas deleted the cast-req branch December 15, 2016 16:05
@fabpot fabpot mentioned this pull request May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants