Skip to content

[Console] MarkdownDescriptor: Strip tags in app headers #20889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Console] MarkdownDescriptor: Strip tags in app headers #20889

wants to merge 1 commit into from

Conversation

ogizanagi
Copy link
Contributor

Q A
Branch? master
Bug fix? yes, should not output tags
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20866
License MIT
Doc PR N/A

For instance, with the Symfony demo:

- Symfony <info>3.3.0-DEV</info> (kernel: <comment>app</>, env: <comment>dev</>, debug: <comment>true</>)
- =======================================================================================================

+ Symfony 3.3.0-DEV (kernel: app, env: dev, debug: true)
+ ======================================================

@ogizanagi
Copy link
Contributor Author

Hmmm... Just realized it might not be relevant to output information like debug, env, ...
I think we should not use Application::getLongVersion() at all actually...

@chalasr
Copy link
Member

chalasr commented Dec 13, 2016

I agree, other descriptors do not use it.

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Dec 13, 2016
@ogizanagi ogizanagi mentioned this pull request Dec 13, 2016
Closed
@ogizanagi
Copy link
Contributor Author

The alternative in #20903

@fabpot
Copy link
Member

fabpot commented Dec 13, 2016

see #20896

@fabpot fabpot closed this Dec 13, 2016
@ogizanagi ogizanagi deleted the fix/console/md/app_header branch December 13, 2016 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Console Status: Needs Review
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@ogizanagi @chalasr @fabpot @nicolas-grekas @carsonbot