Skip to content

[EventDispatcher] Deprecate ContainerAwareEventDispatcher #20937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2017
Merged

[EventDispatcher] Deprecate ContainerAwareEventDispatcher #20937

merged 1 commit into from
Jan 8, 2017

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? no
Fixed tickets -
License MIT
Doc PR -

These methods shouldn't be available to end users.

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Dec 15, 2016
@stof
Copy link
Member

stof commented Dec 15, 2016

👍

@nicolas-grekas nicolas-grekas changed the title [EventDispatcher] Deprecate ContainerAwareEventDispatcher::getContainer() && ::lazyLoad() [EventDispatcher] Deprecate ContainerAwareEventDispatcher Dec 16, 2016
@nicolas-grekas
Copy link
Member Author

PR updated to deprecate the ContainerAwareEventDispatcher class.
To be rebased on top of #20953 before merging.

@xabbuh
Copy link
Member

xabbuh commented Dec 17, 2016

The upgrade files for 3.3 and 4.0 need to be updated too.

@fabpot
Copy link
Member

fabpot commented Jan 7, 2017

Can be rebased now

@fabpot
Copy link
Member

fabpot commented Jan 7, 2017

You should probably update src/Symfony/Bundle/FrameworkBundle/Resources/config/services.xml as well to remove its usage.

@nicolas-grekas
Copy link
Member Author

Rebased. About services.xml, that'd be a BC break because of the getContainer method that people may use...

@fabpot
Copy link
Member

fabpot commented Jan 8, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit c4a6a8a into symfony:master Jan 8, 2017
fabpot added a commit that referenced this pull request Jan 8, 2017
@fabpot
feature #20937 [EventDispatcher] Deprecate ContainerAwareEventDispatc…
e1d3900 
…her (nicolas-grekas)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[EventDispatcher] Deprecate ContainerAwareEventDispatcher

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | no
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

These methods shouldn't be available to end users.

Commits
-------

c4a6a8a [EventDispatcher] Deprecate ContainerAwareEventDispatcher
@javiereguiluz javiereguiluz mentioned this pull request Jan 8, 2017
Closed
@nicolas-grekas nicolas-grekas deleted the event-deprec-getcont branch January 9, 2017 14:01
@chalasr
Copy link
Member

chalasr commented Feb 14, 2017 •
edited
Loading

About services.xml, that'd be a BC break because of the getContainer method that people may use...

It's a bit annoying to get deprecations each time the event_dispatcher service is used until 4.0.
is there any alternative we can provide? Most often there is no need to call getContainer(), only dispatching events (3rd party bundles, functional tests in final apps..)

@TomasVotruba TomasVotruba mentioned this pull request Apr 28, 2017
Merged
7 tasks
@fabpot fabpot mentioned this pull request May 1, 2017
Merged
@greg0ire greg0ire mentioned this pull request Jul 12, 2017
Merged
@jmikola jmikola mentioned this pull request Apr 12, 2018
Open
@totten totten mentioned this pull request May 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Deprecation EventDispatcher Status: Needs Review
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
6 participants
@nicolas-grekas @stof @xabbuh @fabpot @chalasr @carsonbot