[DI] Prepare dropping "strict" handling in loaders #20938
Conversation
c28441f to
f326d95
Compare
| @@ -387,13 +387,7 @@ private function getArgumentsAsPhp(\DOMElement $node, $name, $lowercase = true) | |||
| $invalidBehavior = ContainerInterface::NULL_ON_INVALID_REFERENCE; | |||
| } | |||
|
|
|||
| if ($strict = $arg->getAttribute('strict')) { | |||
There was a problem hiding this comment.
I would still trigger a deprecation if the attribute is there, otherwise we cannot remove it from the XSD in 4.x
There was a problem hiding this comment.
But there is no way to create any continuous upgrade path in XML files. That's why we didn't remove "strict" from the XSD, to allow cross 2x3 bundles. Should we consider this is not required anymore? Not sure on my side (because it doesn't hurt). WDYT?
There was a problem hiding this comment.
But the same is true for the YAML format, isn't it?
There was a problem hiding this comment.
Well, you kept the attribute in the XSD, which is fine to allow the continuous migration. But you should now trigger the deprecation to allow the removal in 4.0
There was a problem hiding this comment.
@xabbuh the YAML format does not have a schema restricting what gets written.
There was a problem hiding this comment.
@stof I meant providing a file that works with both 2.x and 3.x. If we didn't trigger the deprecation with the XML format, it means that we assumed something did set the strict option to false (otherwise you wouldn't need to provide the option at all). However, in YAML that wouldn't be necessary at all.
There was a problem hiding this comment.
@xabbuh setting a reference as not strict is deprecated in 2.8 already. The option is a no-op in 3.0.
So the way to make a file work in 2.8, 3.x and 4.0 is to skip the attribute entirely and avoiding the usage of non-strict references (which are a source of bugs anyway, as it means you bypass the scope restrictions)
f326d95 to
243d160
Compare
|
Thank you @nicolas-grekas. |
…colas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Prepare dropping "strict" handling in loaders | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - "strict" has been deprecated in 2.8, removed from 3.0, but loaders still read them (note that the XSD still mentions it for BC at XML level, but it has no effect.) We could also deprecate the attribute in XML, but I don't see the need since it's already ignored. In YAML, we need people to remove this trailing `=`, which is why the PR is on master with a deprecation. Commits ------- 243d160 [DI] Prepare dropping "strict" handling in loaders
This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] deprecate the strict attribute | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #20938 (comment) | License | MIT | Doc PR | Commits ------- 49cb4db [DI] deprecate the strict attribute
"strict" has been deprecated in 2.8, removed from 3.0, but loaders still read them
(note that the XSD still mentions it for BC at XML level, but it has no effect.)
We could also deprecate the attribute in XML, but I don't see the need since it's already ignored.
In YAML, we need people to remove this trailing
=, which is why the PR is on master with a deprecation.