Skip to content

[DI] Fix DefinitionDecorator deprecation layer #20967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2016

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Dec 17, 2016

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This should make Travis green from 3.1 to master.
ping @xabbuh FYI

Restores compat with instanceof DefinitionDecorator checks.

@nicolas-grekas nicolas-grekas merged commit 14c65e3 into symfony:master Dec 17, 2016
nicolas-grekas added a commit that referenced this pull request Dec 17, 2016
…ekas)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[DI] Fix DefinitionDecorator deprecation layer

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This should make Travis green from 3.1 to master.
ping @xabbuh FYI

Restores compat with `instanceof DefinitionDecorator` checks.

Commits
-------

14c65e3 [DI] Fix DefinitionDecorator deprecation layer
@nicolas-grekas nicolas-grekas deleted the fix-test branch December 17, 2016 10:11
@chalasr
Copy link
Member

chalasr commented Dec 17, 2016

Green it is! 🎉

Thank you @nicolas-grekas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants