[cache] Bump RedisAdapter default timeout to 5s #20991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is also an issue with read_timeout as predis uses read_write_timeout (and again, with predis, 0 means 0s), but just renaming the option would be a BC break |
HeahDude
reviewed
Dec 19, 2016
| @@ -61,7 +61,7 @@ public function __construct($redisClient, $namespace = '', $defaultLifetime = 0) | |||
| * @param string $dsn | |||
| * @param array $options See self::$defaultConnectionOptions | |||
| * | |||
| * @throws InvalidArgumentException When the DSN is invalid. | |||
| * @throws InvalidArgumentException When the DSN is invalid | |||
There was a problem hiding this comment.
This CS fix should target 3.1, so it does not belong to the scope of this PR.
There was a problem hiding this comment.
I would just revert this change as fabbot is unfortunately broken right now. PHP-CS-Fixer 2 is doing things we don't want.
67b93f6 to
ad09b96
Compare
Bump RedisAdapter timeout to 5s because (at least with Predis) 0 means 0s
ad09b96 to
eaca2a4
Compare
|
Thank you @Nicofuma. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 27, 2016
This PR was merged into the 3.1 branch. Discussion ---------- [cache] Bump RedisAdapter default timeout to 5s | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Bump RedisAdapter timeout to 5s because (at least with Predis) 0 means 0s Commits ------- eaca2a4 [cache] Bump RedisAdapter timeout to 5s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump RedisAdapter timeout to 5s because (at least with Predis) 0 means 0s