[TwigBridge] Late deprecation for TwigRendererEngine::setEnvironment() #21021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about this one. AFAIU, the user will now receive two deprecation notices as if they don't pass Twig env as a constructor argument, they probably call the setter. |
|
well, if they pass it in the constructor and still call the setter later, removing the setter would break their app without warning. So we need a deprecation warning there (to avoid the double deprecation warning, we may trigger it only when we already have an environment) |
28d55d1 to
5ef1565
Compare
|
Indeed, updated to avoid the double warning. Should this target 3.2? If so I'll update the corresponding UPGRADE file |
|
3.3 is fine. |
xabbuh
reviewed
Dec 22, 2016
| @@ -217,6 +217,9 @@ TwigBridge | |||
| * The possibility to inject the Form Twig Renderer into the form extension | |||
| has been removed. Inject it into the `TwigRendererEngine` instead. | |||
|
|
|||
| * The `TwigRendererEngine::setEnvironment()` method has been removed. | |||
| Pass the Twig Environment as second argument of the constructor instead. | |||
There was a problem hiding this comment.
Should also be documented in the UPGRADE-3.3.md file.
5ef1565 to
aabb73c
Compare
|
UPGRADE files updated |
|
👍 |
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Dec 23, 2016
…tEnvironment() (chalasr) This PR was merged into the 3.3-dev branch. Discussion ---------- [TwigBridge] Late deprecation for TwigRendererEngine::setEnvironment() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #20093 (comment) | License | MIT | Doc PR | n/a This method should have been deprecated in 3.2 since the twig environment should be injected through the constructor and replacing it later can break things (see #20093 (comment) for details). Maybe this could target 3.2 Commits ------- aabb73c Deprecate TwigRendererEngine::setEnvironment()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method should have been deprecated in 3.2 since the twig environment should be injected through the constructor and replacing it later can break things (see #20093 (comment) for details).
Maybe this could target 3.2