-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[WebProfilerBundle] Added preview iframe for built-in IDE links #21045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Given #21050 (comment) im not really sure about this. It could be too much, the experience is nice though. The approach is simple.. but you can do it easily (custom) in your own projects. Code is here to take 👍 Closing for now. |
@ro0NL : Just to mention: I played a little around with the web profiler in a similar way a while ago, in order to make the whole profiler panel displayable in an iframe, which is pretty convenient to introspect what happens on the current page without leaving it/opening a new tab. |
And switching tabs/windows, which can be huge in terms of experience / doing it many times each day. |
Btw if we could do 50/50 split screen with the profiler, you'd really make my day. This code snippet could work for both.. but i dont know how you did it? Was it less "complex".. better? Having it built-in could be marketing-wise a smart move actually. |
Unfortunately, I think I don't have this snippet anymore. Anyway it was done at the time the 2.7 version was released, so it'll needs some styling tweaks. But the solution is nothing more or less complex than yours, simply exposing the whole profiler in an iframe. |
@javiereguiluz WDYT? Does it solve a case? (considering we can do this for the whole profiler). I understand devs most of the time live with their editor anyway.. so perhaps only this feature brings little value (other then better experience if used, imo.). But to be honest i never considered the whole profiler on this... it blew my mind actually ;-) I could definitely appreciate such a feature! But we shouldnt do it only because it looks pretty or so.. (but yeah.. marketing-wise that also could be a smart move ;-)). Btw. we already have |
I was playing with this a few days ago.. and i just finished it. I really like it :)