[Console] OS X Can't call cli_set_process_title php without superuser #21076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Dec 28, 2016
| @@ -227,7 +227,15 @@ public function run(InputInterface $input, OutputInterface $output) | |||
|
|
|||
| if (null !== $this->processTitle) { | |||
| if (function_exists('cli_set_process_title')) { | |||
| cli_set_process_title($this->processTitle); | |||
| $success = @cli_set_process_title($this->processTitle); | |||
| if (!$success) { | |||
There was a problem hiding this comment.
What about if (@cli_set_process_title($this->processTitle)) { instead?
xabbuh
reviewed
Dec 28, 2016
| $success = @cli_set_process_title($this->processTitle); | ||
| if (!$success) { | ||
| if ('Darwin' === PHP_OS) { | ||
| $output->writeln('<comment>Running "cli_get_process_title" not as a superuser is not supported on OS X.</comment>'); |
There was a problem hiding this comment.
Running "cli_get_process_title()" as an unprivileged user [...]?
There was a problem hiding this comment.
Thanks a lot. It's way better :)
xabbuh
reviewed
Dec 28, 2016
| $output->writeln('<comment>Running "cli_get_process_title" not as a superuser is not supported on OS X.</comment>'); | ||
| } else { | ||
| $error = error_get_last(); | ||
| trigger_error($error['message'], E_USER_WARNING); |
There was a problem hiding this comment.
Instead of E_USER_WARNING this should be $error['type'], shouldn't it?
There was a problem hiding this comment.
Sure. But php forbids to use a E_* error type. Only E_USER_* are allowed.
Here I know it'll always be a E_WARNING as documented in the manual. So I just need to use E_USER_WARNING
xabbuh
reviewed
Dec 28, 2016
| @@ -328,6 +328,11 @@ public function testRunWithProcessTitle() | |||
| $command->setProcessTitle('foo'); | |||
| $this->assertSame(0, $command->run(new StringInput(''), new NullOutput())); | |||
| if (function_exists('cli_set_process_title')) { | |||
| if (null === @cli_get_process_title()) { | |||
| if ('Darwin' === PHP_OS) { | |||
There was a problem hiding this comment.
if (null === @cli_get_process_title() && 'Darwin' === PHP_OS)
|
👍 Status: Reviewed |
fabpot
reviewed
Dec 30, 2016
| cli_set_process_title($this->processTitle); | ||
| if (false === @cli_set_process_title($this->processTitle)) { | ||
| if ('Darwin' === PHP_OS) { | ||
| $output->writeln('<comment>Running "cli_get_process_title" as an unprivileged user is not supported on OS X.</comment>'); |
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Dec 30, 2016
…t superuser (ogizanagi) This PR was merged into the 2.7 branch. Discussion ---------- [Console] OS X Can't call cli_set_process_title php without superuser | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A The console component test suite is failing on OS X (10.12.2) as the `cli_set_process_title` function seems not to be allowed to be called without superuser. It seems to be an OS X limitation. At least, the test suite should pass and a warning should be shown when using the component with this feature on OS X. --- refs: - http://stackoverflow.com/questions/27803120/cannot-set-process-title-in-a-php-command-line-script-using-cli-set-process-titl - liip/php-osx#139 - zfcampus/zf-console#22 Commits ------- 9928c0d [Console] OS X Can't call cli_set_process_title php without superuser
This was referenced Jan 12, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The console component test suite is failing on OS X (10.12.2) as the
cli_set_process_titlefunction seems not to be allowed to be called without superuser. It seems to be an OS X limitation.At least, the test suite should pass and a warning should be shown when using the component with this feature on OS X.
refs: