[Console] Escape default value when dumping help #21078
Conversation
lyrixx
commented
Dec 28, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
The same will apply to arguments (fixed by this patch, but no there is no fixture covering it). |
I know. Adding test is a bit boring + it's already fixed. That's why I did not added fixtures for that. |
| @@ -43,6 +43,8 @@ public static function getInputOptions() | |||
| 'input_option_4' => new InputOption('option_name', 'o', InputOption::VALUE_IS_ARRAY | InputOption::VALUE_OPTIONAL, 'option description', array()), | |||
| 'input_option_5' => new InputOption('option_name', 'o', InputOption::VALUE_REQUIRED, "multiline\noption description"), | |||
| 'input_option_6' => new InputOption('option_name', array('o', 'O'), InputOption::VALUE_REQUIRED, 'option with multiple shortcuts'), | |||
| 'input_option_7' => new InputOption('option_name', 'o', InputOption::VALUE_REQUIRED, 'option description', '<comment>style</>'), | |||
There was a problem hiding this comment.
We should IMO use more descriptive names. Adding a counter suffix leads to merge conflicts that could be avoided.
There was a problem hiding this comment.
Indeed. But I don't know if I should do that right now, in this PR?!
There was a problem hiding this comment.
Agreed. Also it should be scoped to targeted descriptors IMHO (as in #20900).
There was a problem hiding this comment.
I would indeed the new ones better.
There was a problem hiding this comment.
I'm not sure to understand you. So I changed the 'key' and I also added tests for the arguments.
|
👍 |
992f765 to
c242690
Compare
|
👍 Status: Reviewed |
|
Thank you @lyrixx. |
This PR was merged into the 2.7 branch. Discussion ---------- [Console] Escape default value when dumping help | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- c242690 [Console] Escape default value when dumping help