Skip to content

Fixed @return when returning this or static #bis #21100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2016
Merged

Fixed @return when returning this or static #bis #21100

merged 1 commit into from
Dec 30, 2016

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Dec 29, 2016

Q A
Branch? 2.8
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

For some reasons these weren't fixed before #21059 was merged despite the review comments 😆

@fabpot
Copy link
Member

fabpot commented Dec 30, 2016

arf, I forgot to push the changes I did locally :)

@fabpot
Copy link
Member

fabpot commented Dec 30, 2016

Thank you @ogizanagi.

@fabpot fabpot merged commit 20d8c74 into symfony:2.8 Dec 30, 2016
fabpot added a commit that referenced this pull request Dec 30, 2016
…agi)

This PR was merged into the 2.8 branch.

Discussion
----------

Fixed @return when returning this or static #bis

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

For some reasons these weren't fixed before #21059 was merged despite the review comments 😆

Commits
-------

20d8c74 Fixed @return when returning this or static #bis
@ogizanagi ogizanagi deleted the fix/2.8/return_stmt branch December 30, 2016 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants