[PhpUnitBridge] run PHPUnit in the same process #21112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Dec 31, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #21083 |
| License | MIT |
| Doc PR |
|
@julienfalque Can you check if this change solves the issue you described in #21083 (comment) too? |
|
This currently breaks the handling of the exit code (see var $exit). Otherwise I think that's a good way to go. Maybe see if we can do something with OK/KO in a shutdown function ? Or deal with it in .travis.yml file as it was done before. |
9c678fe to
02ef903
Compare
|
Unfortunately, we cannot detect the exit code inside a shutdown function. So we will need to update our Travis CI config after this has been merged. |
| readfile($errFile); | ||
| unlink($errFile); | ||
| } | ||
| include "$PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit"; | ||
|
|
||
| if (!file_exists($component = array_pop($argv))) { |
02ef903 to
1986278
Compare
|
@xabbuh I confirm this solves my issue too :) |
|
@julienfalque Thanks! Happy new year to you! 🎉 |
|
Happy new year :) 🎉 |
|
👍 |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jan 2, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- [PhpUnitBridge] run PHPUnit in the same process | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21083 | License | MIT | Doc PR | Commits ------- 1986278 [PhpUnitBridge] run PHPUnit in the same process
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.