Skip to content

[Yaml] parse multi-line strings #21114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2017
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 31, 2016

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

When working on #21084, I discovered that the YAML parser does not support (unquoted) multi-line strings (neither as plain strings nor as values for mappings). This PR adds support for them.

@javiereguiluz
Copy link
Member

👍

Status: reviewed

@fabpot
Copy link
Member

fabpot commented Jan 8, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit ec593b9 into symfony:master Jan 8, 2017
fabpot added a commit that referenced this pull request Jan 8, 2017
This PR was merged into the 3.3-dev branch.

Discussion
----------

[Yaml] parse multi-line strings

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

When working on #21084, I discovered that the YAML parser does not support (unquoted) multi-line strings (neither as plain strings nor as values for mappings). This PR adds support for them.

Commits
-------

ec593b9 [Yaml] parse multi-line strings
@xabbuh xabbuh deleted the multi-line-strings branch January 8, 2017 16:13
@nicolas-grekas nicolas-grekas modified the milestone: 3.x Mar 24, 2017
@fabpot fabpot mentioned this pull request May 1, 2017
fabpot added a commit that referenced this pull request May 24, 2017
This PR was merged into the 3.3 branch.

Discussion
----------

[Yaml] fix multiline block handling

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21114, #22105 (comment)
| License       | MIT
| Doc PR        |

Commits
-------

a2079d6 [Yaml] fix multiline block handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants