[Validator] do not guess getter method names #21115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Dec 31, 2016
•
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #5219, #18700 |
| License | MIT |
| Doc PR | TODO |
|
Actually, I think that changes made to the |
dunglas
reviewed
Jan 6, 2017
| * | ||
| * @return $this | ||
| */ | ||
| public function addGetterConstraint($property, Constraint $constraint) | ||
| public function addGetterConstraint($property, Constraint $constraint, $method = null) |
There was a problem hiding this comment.
You are right. I have added new methods instead.
|
I also reverted the changes to the Status: Needs Review |
|
ping @symfony/deciders |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Feb 19, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [Validator] do not guess getter method names | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #5219, #18700 | License | MIT | Doc PR | TODO Commits ------- bd3a90a [Validator] do not guess getter method names
This was referenced Mar 6, 2017
Merged
Merged
Merged
teohhanhui
reviewed
Mar 14, 2017
| * @param Constraint $constraint The constraint | ||
| * @param string $property The name of the property | ||
| * @param Constraint $constraint The constraint | ||
| * @param string|null $method The method that is called to retrieve the value being validated (null for auto-detection) |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 14, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [Validator] revert wrong Phpdoc change | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21115 (comment) | License | MIT | Doc PR | Commits ------- 86e8afa [Validator] revert wrong Phpdoc change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.