[TwigBundle] Disable form in tests #21198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ce39e4 to
2a279b9
Compare
|
But it still breaks? |
|
I can't figure out why, it fixed it on my side https://travis-ci.org/chalasr/symfony/builds/189966453. It's like if the changes made here are not took into account |
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 8, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- [TwigBundle] Disable form in tests | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Tests are broken with high deps due to the changes made in #21196 > Symfony\Bundle\TwigBundle\Tests\NoTemplatingEntryTest::test Symfony\Component\DependencyInjection\Exception\LogicException: Form support cannot be enabled as the Translation component is not installed. > Symfony\Bundle\TwigBundle\Tests\NoTemplatingEntryTest::test Symfony\Component\DependencyInjection\Exception\LogicException: The Validator component is required to use the Form component. This will fix them. Commits ------- 2a279b9 [TwigBundle] Disable form in tests
|
got it: the deps=high line on master checks 3.2 out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are broken with high deps due to the changes made in #21196
This will fix them.