[Yaml] Remove internal arguments from the api #21230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure this should be done in a separate PR: it belongs to #21194, and misses a BC layer |
|
I think it's okay to handle it in a separate PR, but it indeed misses the BC layer and should be documented in the upgrade files. |
|
A separate PR will create useless conflicts with #21194, if we happen to pass the array of tag resolvers I was talking about there, but as you want of course. |
|
As I would have to upgrade the bc layer in #21194, I'll do it directly in it. I opened this a bit too quickly 😐 |
xabbuh
added a commit
that referenced
this pull request
Jan 21, 2017
This PR was squashed before being merged into the 3.3-dev branch (closes #21350). Discussion ---------- [Yaml] Remove internal arguments from the api | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #21230 | License | MIT | Doc PR | Reopening of #21230 because of [@xabbuh's comment](#21194 (comment)). > This PR removes internal constructor arguments of the `Parser` class. > This should break nothing as they are only used to build errors message and are clearly meant for internal uses. > > This would allow to have a nicer api for #21194 (comment). Commits ------- ebae4ff [Yaml] Remove internal arguments from the api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes internal constructor arguments of the
Parserclass.This should break nothing as they are only used to build errors message and are clearly meant for internal uses.
This would allow to have a nicer api for #21194 (comment).