[FrameworkBundle] allow to reference files directly from kernel.root_dir #21231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Jan 10, 2017
…om kernel.root_dir (fabpot)
This PR was merged into the 3.3-dev branch.
Discussion
----------
[FrameworkBundle] allow to reference files directly from kernel.root_dir
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
While working on a bundleless app, I want to be able to reference a directory for routing annotations like this:
```yaml
app:
resource: "../src/Controller/"
type: annotation
```
but that does not work because Symfony expects a bundle resource (`@AppBundle...`) or a directory referenced from the main app `Resources` directory. But as I don't have such a directory, even using `../../src/Controller` does not work.
So, I propose to add the %kernel.root_dir% to the list of allowed directories.
By the way, we don't have the same issue with the routing annotation **file** loader as it does not use the locator for whatever reason. Should we fix it?
Commits
-------
80b61e9 [FrameworkBundle] allowed to reference files directly from kernel.root_dir
|
ping @theofidry. We already stumbled on that, this patch will definitely help. |
|
Indeed, cf. symfony/symfony-docs#7228 |
|
@dunglas not sure this solve the issue completely though, as mine was due to removing |
|
@theofidry I don't have an |
|
👍 perfect then, it gave me a lot of trouble so thanks for it |
|
Shouldn't the path be relative to the location of the current file instead, to be consistent with other places in Symfony |
|
I agree with @stof that this makes more sense. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a bundleless app, I want to be able to reference a directory for routing annotations like this:
but that does not work because Symfony expects a bundle resource (
@AppBundle...) or a directory referenced from the main appResourcesdirectory. But as I don't have such a directory, even using../../src/Controllerdoes not work.So, I propose to add the %kernel.root_dir% to the list of allowed directories.
By the way, we don't have the same issue with the routing annotation file loader as it does not use the locator for whatever reason. Should we fix it?