[FrameworkBundle] Fix class_exists() checks in PhpArrayAdapter-related cache warmers #21243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
83807b5 to
9ee969d
Compare
fabpot
reviewed
Jan 12, 2017
| * @param string $phpArrayFile The PHP file where annotations are cached. | ||
| * @param CacheItemPoolInterface $fallbackPool The pool where runtime-discovered annotations are cached. | ||
| * @param string $phpArrayFile the PHP file where annotations are cached | ||
| * @param CacheItemPoolInterface $fallbackPool the pool where runtime-discovered annotations are cached |
There was a problem hiding this comment.
Maj should be reverted, dots can be removed indeed
fabpot
reviewed
Jan 12, 2017
| * @param CacheItemPoolInterface $fallbackPool The pool where runtime-discovered metadata are cached. | ||
| * @param LoaderInterface[] $loaders the serializer metadata loaders | ||
| * @param string $phpArrayFile the PHP file where metadata are cached | ||
| * @param CacheItemPoolInterface $fallbackPool the pool where runtime-discovered metadata are cached |
9ee969d to
e09dccc
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jan 12, 2017
…pter-related cache warmers (nicolas-grekas, mpajunen) This PR was merged into the 3.2 branch. Discussion ---------- [FrameworkBundle] Fix class_exists() checks in PhpArrayAdapter-related cache warmers | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up of #21102 Commits ------- e09dccc [FrameworkBundle] Add annotated validator cache test case c60009e [FrameworkBundle] Fix class_exists() checks in PhpArrayAdapter-related cache warmers
Merged
sstok
reviewed
Jan 22, 2017
| @@ -17,7 +17,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=5.5.9", | |||
| "symfony/cache": "~3.2", | |||
| "symfony/cache": "~3.2.2|~3.3", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #21102