Fix ICU dependant tests #21320
Merged
Fix ICU dependant tests #21320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakzal
commented
Jan 17, 2017
| @@ -108,10 +108,10 @@ public function testReverseTransformEmpty() | |||
|
|
|||
| public function testReverseTransformWithGrouping() | |||
| { | |||
| // Since we test against "de_AT", we need the full implementation | |||
| // Since we test against "de_DE", we need the full implementation | |||
There was a problem hiding this comment.
German data seems to be changing less often.
is this table built before or after your change ? |
|
@stof after my change. Here's the current 2.7:
|
|
👍 |
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Jan 24, 2017
This PR was squashed before being merged into the 2.7 branch (closes #21320). Discussion ---------- Fix ICU dependant tests | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - #20551 changed the condition checking if the ICU version matches the stubbed data. The change intended to enable tests on more ICU versions, but it actually has limited them. I'm still not convinced it should've been done but let's at least fix the condition. Ideal solution would be to have the latest ICU data available on travis (still not there travis-ci/travis-ci#3616). I also needed to fix several tests. Currently skipped tests in components depending on ICU data: | | 4.8.1.1 | 54.1 | 55.1 | 57.1 | |---|---|--|--|--| | Intl | 488 | 488 | 7 | 6 | | Locale | 0 | 0 | 0 | 0 | | Translation| 0 | 0 | 0 | 0 | | Validator | 69 | 69 | 69 | 0 | | Form | 75 | 75 | 75 | 1 | Commits ------- d3b5d8e Fix tests with ICU 57.1 677d820 Fix the condition checking the minimum ICU version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20551 changed the condition checking if the ICU version matches the stubbed data. The change intended to enable tests on more ICU versions, but it actually has limited them. I'm still not convinced it should've been done but let's at least fix the condition. Ideal solution would be to have the latest ICU data available on travis (still not there travis-ci/travis-ci#3616).
I also needed to fix several tests.
Currently skipped tests in components depending on ICU data: