[Validator] Improved error message for missing upload_tmp_dir #21335

Breuls · 2017-01-18T15:07:33Z

Q	A
Branch?	2.7
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	N/A
License	MIT
Doc PR	N/A

I ran into a problem in which the value for upload_tmp_dir was set in php.ini, but PHP was unable to write to the specified location. PHP returns an UPLOAD_ERR_NO_TMP_DIR in $_FILES when it can't find or use the tmp dir, and my application displayed the error for $uploadNoTmpDirErrorMessage, from which I drew the conclusion that the ini setting was missing or emtpy.

This conclusion was based on the wording in the error message, which explicitly states that 'no temporary folder was configured', which is not actually correct. According to the PHP documentation:

UPLOAD_ERR_NO_TMP_DIR
Value: 6; Missing a temporary folder. Introduced in PHP 5.0.3.

'Missing' might be interpreted as 'the value for the ini setting is missing', but also as 'the configured folder is missing'.

I thought it might save someone some time if the error message from the Symfony Validator makes this explicit, which is what this PR aims to do.

I also updated the Dutch and Polish translations, because those, in addition to English, are the languages spoken in my team.

xabbuh · 2017-01-18T17:36:29Z

src/Symfony/Component/Validator/Constraints/File.php

@@ -50,7 +50,7 @@ class File extends Constraint
    public $uploadFormSizeErrorMessage = 'The file is too large.';
    public $uploadPartialErrorMessage = 'The file was only partially uploaded.';
    public $uploadNoFileErrorMessage = 'No file was uploaded.';
-    public $uploadNoTmpDirErrorMessage = 'No temporary folder was configured in php.ini.';
+    public $uploadNoTmpDirErrorMessage = 'No temporary folder was configured in php.ini, or the configured folder does not exist.';


This should stay the same. If we made the change here, this would be a BC break for everyone using their own translations. Instead, we can just change the target value in the validators.en.xml file.

Ah, I didn't know that was a possibility.

I've updated the PR; only the language files for EN, NL and PL now have the change.

javiereguiluz · 2017-01-20T08:38:05Z

👍

xabbuh · 2017-01-20T09:00:43Z

👍

@jakzal @iltar @wouterj Can you review the Polish and Dutch translations?

linaori · 2017-01-20T09:11:28Z

Current:

Er is geen tijdelijke map geconfigureerd in php.ini, of de geconfigureerde map
bestaat niet.

Proposal:

Er is geen tijdelijke folder geconfigureerd in php.ini, of de geconfigureerde folder
bestaat niet.

Not 100% sure about the original text. It's not wrong, but it feels a bit like google translate.

Breuls · 2017-01-20T10:20:33Z

@iltar 'folder' isn't actually a Dutch word, so it seems odd to change 'map' to 'folder'.

jakzal · 2017-01-20T10:44:05Z

src/Symfony/Component/Validator/Resources/translations/validators.pl.xlf

@@ -192,7 +192,7 @@
            </trans-unit>
            <trans-unit id="51">
                <source>No temporary folder was configured in php.ini.</source>
-                <target>Nie skonfigurowano folderu tymczasowego w php.ini.</target>
+                <target>Nie skonfigurowano folderu tymczasowego w php.ini, lub folder konfiguracji nie istnieje.</target>


Nie skonfigurowano folderu tymczasowego w php.ini, lub skonfigurowany folder nie istnieje.

linaori · 2017-01-20T11:24:43Z

After a small discussion on slack in #dutch, we came up with this:

Er is geen tijdelijke map geconfigureerd in de php.ini, of de gespecifiëerde map bestaat niet.

Breuls · 2017-01-20T11:45:18Z

Allright, that's fine. I'll make it "gespecificeerde" though, as "gespecifiëerde" also doesn't exist. ;)

fabpot · 2017-01-20T14:46:06Z

@Breuls What about @jakzal suggestion for the Polish version?

Breuls · 2017-01-21T08:50:35Z

@fabpot Sorry, missed that. I didn't write the original proposal, but I've updated it now.

jakzal · 2017-01-21T09:30:07Z

👍

fabpot · 2017-01-21T18:14:56Z

Thank you @Breuls.

…p_dir (Breuls) This PR was merged into the 2.7 branch. Discussion ---------- [Validator] Improved error message for missing upload_tmp_dir | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A I ran into a problem in which the value for upload_tmp_dir was set in php.ini, but PHP was unable to write to the specified location. PHP returns an UPLOAD_ERR_NO_TMP_DIR in $_FILES when it can't find or use the tmp dir, and my application displayed the error for $uploadNoTmpDirErrorMessage, from which I drew the conclusion that the ini setting was missing or emtpy. This conclusion was based on the wording in the error message, which explicitly states that 'no temporary folder was configured', which is not actually correct. According to the [PHP documentation](http://php.net/manual/en/features.file-upload.errors.php): > UPLOAD_ERR_NO_TMP_DIR > Value: 6; Missing a temporary folder. Introduced in PHP 5.0.3. 'Missing' might be interpreted as 'the value for the ini setting is missing', but also as 'the configured folder is missing'. I thought it might save someone some time if the error message from the Symfony Validator makes this explicit, which is what this PR aims to do. I also updated the Dutch and Polish translations, because those, in addition to English, are the languages spoken in my team. Commits ------- afbf227 [Validator] Improved error message for missing upload_tmp_dir

…alidation secti… (davewwww) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] add "mapping" configuration key at validation secti… | Q | A | | --- | --- | | Bug fix? | no | | New feature? | yes | | BC breaks? | no | | Deprecations? | no | | Tests pass? | yes | | Fixed tickets | #15655 | | License | MIT | | Doc PR | symfony/symfony-docs#7407 | This feature allows you, to define additional validation files or directories which are not in the 'Bundle*/Resources/config/' directory. ``` yaml #config.yml framework: validation: mapping: paths: - "path/to/file/validation.yml" - "path/to/file/validation.xml" - "path/to/another/directory" ``` Commits ------- d696cfb [FrameworkBundle] Configurable paths for validation files 60d7d43 fix merge 61475b5 Merge branch '3.2' ba41e70 Merge branch '3.1' into 3.2 4268aba Merge branch '2.8' into 3.1 3faf655 Merge branch '2.7' into 2.8 e95fc09 fix getMock usage 482828c fix merge ed5eb6d bug #21372 [DependencyInjection] Fixed variadic method parameter in autowired classes (brainexe) a7f63de [DependencyInjection] Fixed variadic method parameter in autowired classes 9ef4271 minor #21371 [Validator] update German translation (xabbuh) f920e61 update German translation 41c72ab minor #21335 [Validator] Improved error message for missing upload_tmp_dir (Breuls) afbf227 [Validator] Improved error message for missing upload_tmp_dir

Also adjusted trans-unit "51" to commit symfony#21335

Also adjusted trans-unit "51" to commit #21335

…on (mweimerskirch) This PR was submitted for the 3.3 branch but it was merged into the 2.7 branch instead (closes #24719). Discussion ---------- Fixed a few spelling mistakes in Luxembourgish translation Fixed a few spelling mistakes in Luxembourgish translation and also adjusted trans-unit "51" to commit #21335 | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? |no | Tests pass? | yes | License | MIT Commits ------- 7a81576 Fixed a few spelling mistakes in Luxembourgish translation

…gusz) This PR was squashed before being merged into the 3.4 branch. Discussion ---------- [Validator] Remove commas in translations | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT These translations were originally modified in #21335. Commits ------- 5688f97 [Validator] Remove commas in translations

carsonbot added Status: Needs Review Validator labels Jan 18, 2017

xabbuh requested changes Jan 18, 2017

View reviewed changes

javiereguiluz added Enhancement Status: Reviewed and removed Status: Needs Review labels Jan 20, 2017

jakzal reviewed Jan 20, 2017

View reviewed changes

xabbuh approved these changes Jan 20, 2017

View reviewed changes

[Validator] Improved error message for missing upload_tmp_dir

afbf227

fabpot merged commit afbf227 into symfony:2.7 Jan 21, 2017

mweimerskirch added a commit to mweimerskirch/symfony that referenced this pull request Oct 28, 2017

Fixed a few spelling mistakes in Luxembourgish translation

9f65bf6

Also adjusted trans-unit "51" to commit symfony#21335

mweimerskirch mentioned this pull request Oct 28, 2017

Fixed a few spelling mistakes in Luxembourgish translation #24719

Closed

nicolas-grekas pushed a commit that referenced this pull request Oct 28, 2017

Fixed a few spelling mistakes in Luxembourgish translation

7a81576

Also adjusted trans-unit "51" to commit #21335

przemyslaw-bogusz mentioned this pull request Mar 10, 2020

[Validator] Remove commas in translations #36021

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Validator] Improved error message for missing upload_tmp_dir #21335

[Validator] Improved error message for missing upload_tmp_dir #21335

Breuls commented Jan 18, 2017

xabbuh Jan 18, 2017

Breuls Jan 18, 2017

javiereguiluz commented Jan 20, 2017

xabbuh commented Jan 20, 2017

linaori commented Jan 20, 2017

Breuls commented Jan 20, 2017

jakzal Jan 20, 2017

linaori commented Jan 20, 2017

Breuls commented Jan 20, 2017

fabpot commented Jan 20, 2017

Breuls commented Jan 21, 2017

jakzal commented Jan 21, 2017

fabpot commented Jan 21, 2017

[Validator] Improved error message for missing upload_tmp_dir #21335

[Validator] Improved error message for missing upload_tmp_dir #21335

Conversation

Breuls commented Jan 18, 2017

xabbuh Jan 18, 2017

Choose a reason for hiding this comment

Breuls Jan 18, 2017

Choose a reason for hiding this comment

javiereguiluz commented Jan 20, 2017

xabbuh commented Jan 20, 2017

linaori commented Jan 20, 2017

Breuls commented Jan 20, 2017

jakzal Jan 20, 2017

Choose a reason for hiding this comment

linaori commented Jan 20, 2017

Breuls commented Jan 20, 2017

fabpot commented Jan 20, 2017

Breuls commented Jan 21, 2017

jakzal commented Jan 21, 2017

fabpot commented Jan 21, 2017