[FrameworkBundle] Execute the PhpDocExtractor earlier #21370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure it should go on master to me. To reviewers: please advise your pov :) |
|
@nicolas-grekas do you think it should go in 2.8? It is fine for me either way. |
|
Looks like a bug fix to me. |
|
@dunglas's comment on the issue is interesting; it was done for performance reasons. This change makes sense but can we check that performance is still ok? |
|
@fabpot that's why there is a cache layer, i don't think it's relevant. |
|
Thank you @GuilhemN. |
fabpot
added a commit
that referenced
this pull request
Jan 30, 2017
…lhemN) This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #21370). Discussion ---------- [FrameworkBundle] Execute the PhpDocExtractor earlier | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes, but safer to apply on master | New feature? | no | BC breaks? | is changing a priority a bc break? | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21367 | License | MIT | Doc PR | Fixes #21367. > I wonder if this is logical to execute the PhpDocExtractor after the ReflectionExtractor: when you use phpdocs it's because they are more precise than php type hints. This causes an issue in NelmioApiDocBundle, for example you can't use int[] with a setter as the type mixed[] will be returned instead of int[]. > > ~~Would you accept bumping its priority to -999?~~ This PR changes the priority of the `ReflectionExtractor` to `-1002` to make sure it is executed after the `PhpDocExtractor`. Commits ------- 0425e05 [FrameworkBundle] Execute the PhpDocExtractor earlier
fabpot
added a commit
that referenced
this pull request
Jan 31, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] Fix tests | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Travis is red because of the new test introduced in #21370. This should make it green again. Commits ------- 1bf451c [FrameworkBundle] Fix tests
nicolas-grekas
added a commit
that referenced
this pull request
Feb 1, 2017
… case (xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle] add missing functional Serializer test case | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This is needed to make the test introduced in #21370. It basically backports the functional test config as introduced by @dunglas in #20480. Commits ------- 24243ac add missing functional Serializer test case
|
This has caused BC break in my app. 😞 |
|
@teohhanhui Please open a new issue describing the BC break you experience. Here your comment will likely get lost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21367.
This PR changes the priority of the
ReflectionExtractorto-1002to make sure it is executed after thePhpDocExtractor.