Force load translator since templating is enabled with php engine #21374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e61f4be to
cb17221
Compare
aitboudad
approved these changes
Jan 23, 2017
Koc
reviewed
Jan 23, 2017
| @@ -110,6 +111,10 @@ public function load(array $configs, ContainerBuilder $container) | |||
| throw new LogicException('Validation support cannot be enabled as the Translation component is not installed.'); | |||
| } | |||
|
|
|||
| if (!class_exists('Symfony\Component\Translation\Translator') && $isTemplatingPHPEngineEnabled) { | |||
There was a problem hiding this comment.
you can use ::class notation here
There was a problem hiding this comment.
Because that's what we are doing now.
|
Wouldn't it be better to remove the |
|
@xabbuh I have no personal opinion on this. @fabpot @aitboudad what do you think ? |
|
seems better to me |
|
I agree with @xabbuh. |
|
@inalgnu do you have time to finish this PR? status: needs work |
fabpot
added a commit
that referenced
this pull request
Mar 17, 2017
…s disabled (xabbuh) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] remove translator helper if Translator is disabled | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20928 (comment), #21374 | License | MIT | Doc PR | Commits ------- 25ea510 remove translator helper if Translator is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will fix a bug introduced in #20928
The "templating.helper.translator" service has a dependency on translator and container compilation will break if templating engine is set to "php" only.