[DI][Config] Add & use ReflectionClassResource #21419
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,171 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\Config\Resource; | ||
|
|
||
| /** | ||
| * @author Nicolas Grekas <p@tchwork.com> | ||
| */ | ||
| class ReflectionClassResource implements SelfCheckingResourceInterface, \Serializable | ||
| { | ||
| private $files = array(); | ||
| private $className; | ||
| private $classReflector; | ||
| private $hash; | ||
|
|
||
| public function __construct(\ReflectionClass $classReflector) | ||
| { | ||
| $this->className = $classReflector->name; | ||
| $this->classReflector = $classReflector; | ||
| } | ||
|
|
||
| public function isFresh($timestamp) | ||
| { | ||
| if (null === $this->hash) { | ||
| $this->hash = $this->computeHash(); | ||
| $this->loadFiles($this->classReflector); | ||
| } | ||
|
|
||
| foreach ($this->files as $file => $v) { | ||
| if (!file_exists($file)) { | ||
| return false; | ||
| } | ||
|
|
||
| if (@filemtime($file) > $timestamp) { | ||
| return $this->hash === $this->computeHash(); | ||
| } | ||
| } | ||
|
|
||
| return true; | ||
| } | ||
|
|
||
| public function __toString() | ||
| { | ||
| return 'reflection.'.$this->className; | ||
| } | ||
|
|
||
| public function serialize() | ||
| { | ||
| if (null === $this->hash) { | ||
| $this->hash = $this->computeHash(); | ||
| $this->loadFiles($this->classReflector); | ||
| } | ||
|
|
||
| return serialize(array($this->files, $this->className, $this->hash)); | ||
| } | ||
|
|
||
| public function unserialize($serialized) | ||
| { | ||
| list($this->files, $this->className, $this->hash) = unserialize($serialized); | ||
| } | ||
|
|
||
| private function loadFiles(\ReflectionClass $class) | ||
| { | ||
| foreach ($class->getInterfaces() as $v) { | ||
| $this->loadFiles($v); | ||
| } | ||
| do { | ||
| $file = $class->getFileName(); | ||
| if (false !== $file && file_exists($file)) { | ||
| $this->files[$file] = null; | ||
| } | ||
| foreach ($class->getTraits() as $v) { | ||
| $this->loadFiles($v); | ||
| } | ||
| } while ($class = $class->getParentClass()); | ||
| } | ||
|
|
||
| private function computeHash() | ||
| { | ||
| if (null === $this->classReflector) { | ||
| try { | ||
| $this->classReflector = new \ReflectionClass($this->className); | ||
| } catch (\ReflectionException $e) { | ||
| // the class does not exist anymore | ||
| return false; | ||
| } | ||
| } | ||
| $hash = hash_init('md5'); | ||
|
|
||
| foreach ($this->generateSignature($this->classReflector) as $info) { | ||
| hash_update($hash, $info); | ||
| } | ||
|
|
||
| return hash_final($hash); | ||
| } | ||
|
|
||
| private function generateSignature(\ReflectionClass $class) | ||
| { | ||
| yield $class->getDocComment().$class->getModifiers(); | ||
|
|
||
| if ($class->isTrait()) { | ||
| yield print_r(class_uses($class->name), true); | ||
|
There was a problem hiding this comment. shouldn't this be always included ? There was a problem hiding this comment. no need: traits are not directly part of the signature - the methods they provide will be seen as any other methods, thus tracked |
||
| } else { | ||
| yield print_r(class_parents($class->name), true); | ||
| yield print_r(class_implements($class->name), true); | ||
| yield print_r($class->getConstants(), true); | ||
| } | ||
|
|
||
| if (!$class->isInterface()) { | ||
| $defaults = $class->getDefaultProperties(); | ||
|
|
||
| foreach ($class->getProperties(\ReflectionProperty::IS_PUBLIC | \ReflectionProperty::IS_PROTECTED) as $p) { | ||
| yield $p->getDocComment().$p; | ||
| yield print_r($defaults[$p->name], true); | ||
| } | ||
| } | ||
|
|
||
| if (defined('HHVM_VERSION')) { | ||
| foreach ($class->getMethods(\ReflectionMethod::IS_PUBLIC | \ReflectionMethod::IS_PROTECTED) as $m) { | ||
| // workaround HHVM bug with variadics, see https://github.com/facebook/hhvm/issues/5762 | ||
| yield preg_replace('/^ @@.*/m', '', new ReflectionMethodHhvmWrapper($m->class, $m->name)); | ||
| } | ||
| } else { | ||
| foreach ($class->getMethods(\ReflectionMethod::IS_PUBLIC | \ReflectionMethod::IS_PROTECTED) as $m) { | ||
| yield preg_replace('/^ @@.*/m', '', $m); | ||
|
|
||
| $defaults = array(); | ||
| foreach ($m->getParameters() as $p) { | ||
| $defaults[$p->name] = $p->isDefaultValueAvailable() ? $p->getDefaultValue() : null; | ||
| } | ||
| yield print_r($defaults, true); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @internal | ||
| */ | ||
| class ReflectionMethodHhvmWrapper extends \ReflectionMethod | ||
| { | ||
| public function getParameters() | ||
| { | ||
| $params = array(); | ||
|
|
||
| foreach (parent::getParameters() as $i => $p) { | ||
| $params[] = new ReflectionParameterHhvmWrapper(array($this->class, $this->name), $i); | ||
| } | ||
|
|
||
| return $params; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @internal | ||
| */ | ||
| class ReflectionParameterHhvmWrapper extends \ReflectionParameter | ||
| { | ||
| public function getDefaultValue() | ||
| { | ||
| return array($this->isVariadic(), $this->isDefaultValueAvailable() ? parent::getDefaultValue() : null); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transitivity and composer bug, this doesn't change the result, it only helps composer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I was just wondering as the code changes didn't indicate any need for this change