Casting TableCell value to string. #21430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP throws a catchable fatal error when the value from this method is used in strstr in the Table class.
|
Taking it strictly the current behaviour is not wing as the |
|
Looks like a feature to me, it is the expected behavior on 2.7. |
Mis-read the comment by @stof in symfony#21429
|
👍 on 2.7, minor tweak to me |
|
I would only cast for ints then. |
|
@jaydiablo Can you make the change @fabpot asked for? :) |
|
Sure, what about other numeric values that aren't ints? Like a float. Should we wrap the cast in something like: if (is_numeric($value) && !is_string($value)) {? |
|
My point was that I don't want to have a cast to a string for objects for instance. |
|
Thank you @jaydiablo. |
fabpot
added a commit
that referenced
this pull request
Feb 3, 2017
This PR was squashed before being merged into the 2.7 branch (closes #21430). Discussion ---------- Casting TableCell value to string. | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21429 | License | MIT | Doc PR | PHP throws a catchable fatal error when the value from this method is used in strstr in the Table class. This fixes the error by casting to a string before returning the value. Commits ------- 1e5707f Casting TableCell value to string.
This was referenced Feb 6, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP throws a catchable fatal error when the value from this method is
used in strstr in the Table class. This fixes the error by casting to a string before returning the value.