-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Config][DI] Add ComposerResource to track the runtime engine + deps #21505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 94 additions & 0 deletions
94
src/Symfony/Component/Config/Resource/ComposerResource.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\Config\Resource; | ||
|
|
||
| /** | ||
| * ComposerResource tracks the PHP version and Composer dependencies. | ||
| * | ||
| * @author Nicolas Grekas <p@tchwork.com> | ||
| */ | ||
| class ComposerResource implements SelfCheckingResourceInterface, \Serializable | ||
| { | ||
| private $versions; | ||
| private $vendors; | ||
|
|
||
| private static $runtimeVersion; | ||
| private static $runtimeVendors; | ||
|
|
||
| public function __construct() | ||
| { | ||
| self::refresh(); | ||
| $this->versions = self::$runtimeVersion; | ||
| $this->vendors = self::$runtimeVendors; | ||
| } | ||
|
|
||
| public function getVendors() | ||
| { | ||
| return array_keys($this->vendors); | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function __toString() | ||
| { | ||
| return __CLASS__; | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function isFresh($timestamp) | ||
| { | ||
| self::refresh(); | ||
|
|
||
| if (self::$runtimeVersion !== $this->versions) { | ||
| return false; | ||
| } | ||
|
|
||
| return self::$runtimeVendors === $this->vendors; | ||
| } | ||
|
|
||
| public function serialize() | ||
| { | ||
| return serialize(array($this->versions, $this->vendors)); | ||
| } | ||
|
|
||
| public function unserialize($serialized) | ||
| { | ||
| list($this->versions, $this->vendors) = unserialize($serialized); | ||
| } | ||
|
|
||
| private static function refresh() | ||
| { | ||
| if (null !== self::$runtimeVersion) { | ||
| return; | ||
| } | ||
|
|
||
| self::$runtimeVersion = array(); | ||
| self::$runtimeVendors = array(); | ||
|
|
||
| foreach (get_loaded_extensions() as $ext) { | ||
| self::$runtimeVersion[$ext] = phpversion($ext); | ||
| } | ||
|
|
||
| foreach (get_declared_classes() as $class) { | ||
| if ('C' === $class[0] && 0 === strpos($class, 'ComposerAutoloaderInit')) { | ||
| $r = new \ReflectionClass($class); | ||
| $v = dirname(dirname($r->getFileName())); | ||
| if (file_exists($v.'/composer/installed.json')) { | ||
| self::$runtimeVendors[$v] = @filemtime($v.'/composer/installed.json'); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
src/Symfony/Component/Config/Tests/Resource/ComposerResourceTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\Config\Tests\Resource; | ||
|
|
||
| use Composer\Autoload\ClassLoader; | ||
| use Symfony\Component\Config\Resource\ComposerResource; | ||
|
|
||
| class ComposerResourceTest extends \PHPUnit_Framework_TestCase | ||
| { | ||
| public function testGetVendor() | ||
| { | ||
| $res = new ComposerResource(); | ||
|
|
||
| $r = new \ReflectionClass(ClassLoader::class); | ||
| $found = false; | ||
|
|
||
| foreach ($res->getVendors() as $vendor) { | ||
| if ($vendor && 0 === strpos($r->getFileName(), $vendor)) { | ||
| $found = true; | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| $this->assertTrue($found); | ||
| } | ||
|
|
||
| public function testSerializeUnserialize() | ||
| { | ||
| $res = new ComposerResource(); | ||
| $ser = unserialize(serialize($res)); | ||
|
|
||
| $this->assertTrue($res->isFresh(0)); | ||
| $this->assertTrue($ser->isFresh(0)); | ||
|
|
||
| $this->assertEquals($res, $ser); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't you replace the file_exists check above instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need: if the file does not exist, we should not track its non-existence