Skip to content

[HttpKernel][FrameworkBundle] Lazy load argument value resolvers #21516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2017

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Feb 2, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

The ArgumentResolver resolves an arg using the first ArgumentValueResolver which supports() it (which can be complex, see e.g. sensiolabs/SensioFrameworkExtraBundle#436).

@fabpot
Copy link
Member

fabpot commented Feb 2, 2017

👍

@chalasr chalasr force-pushed the lazy-argument-value-resolvers branch from 62e7075 to 02b4aaa Compare February 2, 2017 19:36
@fabpot
Copy link
Member

fabpot commented Feb 2, 2017

Thank you @chalasr.

@fabpot fabpot merged commit 02b4aaa into symfony:master Feb 2, 2017
fabpot added a commit that referenced this pull request Feb 2, 2017
… resolvers (chalasr)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[HttpKernel][FrameworkBundle] Lazy load argument value resolvers

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

The ArgumentResolver resolves an arg using the first ArgumentValueResolver which `supports()` it (which can be complex, see e.g. [sensiolabs/SensioFrameworkExtraBundle#436](https://github.com/sensiolabs/SensioFrameworkExtraBundle/pull/436/files#diff-865d48d9369c4431bce36ba642834570R10)).

Commits
-------

02b4aaa [HttpKernel] Lazy load argument value resolvers
@chalasr chalasr deleted the lazy-argument-value-resolvers branch February 3, 2017 00:00
@fabpot fabpot mentioned this pull request May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants