[TwigBridge] Add docblocks for Twig url and path function to improve ide completion #21536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,11 +40,25 @@ public function getFunctions() | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * @param string $name | |||
| * @param array $parameters | |||
1c58e89 to
93ab017
Compare
|
Thank you @Haehnchen. |
fabpot
added a commit
that referenced
this pull request
Feb 16, 2017
…n to improve ide completion (Haehnchen) This PR was merged into the 2.7 branch. Discussion ---------- [TwigBridge] Add docblocks for Twig url and path function to improve ide completion | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT `RoutingExtension` missed docblock for Twig extension so `path` and `url` are not fully recognized by PhpStorm. Haehnchen/idea-php-symfony2-plugin#864 will add more smarter completion `{{ p<caret> }} -> {{ path('<caret>') }}`, but string parameter is not detected. This will add the minimal docs Commits ------- 93ab017 add docblocks for Twig url and path function to improve ide completion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoutingExtensionmissed docblock for Twig extension sopathandurlare not fully recognized by PhpStorm.Haehnchen/idea-php-symfony2-plugin#864 will add more smarter completion
{{ p<caret> }} -> {{ path('<caret>') }}, but string parameter is not detected. This will add the minimal docs