[FrameworkBundle] Wire ArrayCache for annotation reader at bootstrap #21556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 7, 2017
stof
reviewed
Feb 7, 2017
| if ($container->hasAlias($provider = $tags['annotations.cached_reader'][0]['provider'])) { | ||
| $provider = (string) $container->getAlias($provider); | ||
| } | ||
| $container->set('annotations.cached_reader', null); |
There was a problem hiding this comment.
not in #21533 (methodMap is empty in ContainerBuilder), but in #19668 yes - yet I think we should not merge it as explained implicitly :)
|
This patch seems to fix this issue: #21559 that is present on v3.2.3 As you can see on blackfire: This patch still have a +2,39% negative impact on performance, but it's still better than +2020% of negative impact :-) |
|
also fixes the #21576 Thanks |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2017
… bootstrap (nicolas-grekas) This PR was merged into the 3.2 branch. Discussion ---------- [FrameworkBundle] Wire ArrayCache for annotation reader at bootstrap | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21549 | License | MIT | Doc PR | - Related to #21381 which disabled any cache at bootstrap. Instead, this wires ArrayCache during bootstrapping, then swaps the cache provider for the real one. Commits ------- f90f53e [FrameworkBundle] Wire ArrayCache for annotation reader at bootstrap
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #21381 which disabled any cache at bootstrap.
Instead, this wires ArrayCache during bootstrapping, then swaps the cache provider for the real one.