Skip to content

[Translation] Added a lint:xliff command for XLIFF files #21578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Translation] Added a lint:xliff command for XLIFF files #21578

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4ae5bf
[Translation] Added a lint:translation command for XLIFF files
javiereguiluz Feb 10, 2017
b64b3d9
Fixed the issues pointed out by reviewers
javiereguiluz Feb 10, 2017
fcae25e
Renamed "lint:translation" to "lint:xliff"
javiereguiluz Feb 12, 2017
55bd4b6
Use a Yoda condition
javiereguiluz Feb 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Renamed "lint:translation" to "lint:xliff"
  • Loading branch information
@javiereguiluz
javiereguiluz committed Feb 12, 2017
commit fcae25e837ab24a57d25ad69218cdeddbbfa287f
6 changes: 3 additions & 3 deletions ...Bundle/Command/TranslationLintCommand.php → ...meworkBundle/Command/XliffLintCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Translation\Command\LintCommand as BaseLintCommand;
use Symfony\Component\Translation\Command\XliffLintCommand as BaseLintCommand;

/**
* Validates XLIFF files syntax and outputs encountered errors.
Expand All @@ -23,7 +23,7 @@
* @author Robin Chalas <robin.chalas@gmail.com>
* @author Javier Eguiluz <javier.eguiluz@gmail.com>
*/
class TranslationLintCommand extends Command
class XliffLintCommand extends Command
{
private $command;

Expand All @@ -32,7 +32,7 @@ class TranslationLintCommand extends Command
*/
protected function configure()
{
$this->setName('lint:translation');
$this->setName('lint:xliff');

if (!$this->isEnabled()) {
return;
Expand Down
6 changes: 3 additions & 3 deletions ...onent/Translation/Command/LintCommand.php → .../Translation/Command/XliffLintCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* @author Robin Chalas <robin.chalas@gmail.com>
* @author Javier Eguiluz <javier.eguiluz@gmail.com>
*/
class LintCommand extends Command
class XliffLintCommand extends Command
{
private $parser;
private $format;
Expand All @@ -46,8 +46,8 @@ public function __construct($name = null, $directoryIteratorProvider = null, $is
protected function configure()
{
$this
->setName('lint:translation')
->setDescription('Lints a file and outputs encountered errors')
->setName('lint:xliff')
->setDescription('Lints a XLIFF file and outputs encountered errors')
->addArgument('filename', null, 'A file or a directory or STDIN')
->addOption('format', null, InputOption::VALUE_REQUIRED, 'The output format', 'txt')
->setHelp(<<<EOF
Expand Down