[Process] Permit empty suffix on Windows #21613
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilge
commented
Feb 14, 2017
| @@ -75,7 +75,7 @@ public function find($name, $default = null, array $extraDirs = array()) | |||
| $suffixes = array(''); | |||
| if ('\\' === DIRECTORY_SEPARATOR) { | |||
| $pathExt = getenv('PATHEXT'); | |||
| $suffixes = $pathExt ? explode(PATH_SEPARATOR, $pathExt) : $this->suffixes; | |||
| $suffixes = array_merge($suffixes, $pathExt ? explode(PATH_SEPARATOR, $pathExt) : $this->suffixes); | |||
There was a problem hiding this comment.
Here we are merging the Windows suffixes with the previously-defined empty suffix on line 75, instead of overwriting the empty suffix list as previously.
|
Thank you @Bilge. |
fabpot
added a commit
that referenced
this pull request
Feb 16, 2017
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #21613). Discussion ---------- [Process] Permit empty suffix on Windows | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | It is a fallacy to assume the blank suffix is not applicable on Windows systems, especially in a world where we often emulate Linux systems with solutions such as CYGWIN, MinGW and MSYS. Commits ------- 412db4c Permit empty suffix on Windows
|
Thank you @fabpot 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a fallacy to assume the blank suffix is not applicable on Windows systems, especially in a world where we often emulate Linux systems with solutions such as CYGWIN, MinGW and MSYS.