Skip to content

[DI][FrameworkBundle] ServiceLocator: fix XmlDescriptor to use dashes #21615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2017
Merged

[DI][FrameworkBundle] ServiceLocator: fix XmlDescriptor to use dashes #21615

merged 1 commit into from
Feb 16, 2017

Conversation

ogizanagi
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #21600 (comment)
License MIT
Doc PR N/A

As reported by @stof, I should have used dashes, not underscores. My bad...

@fabpot
Copy link
Member

fabpot commented Feb 16, 2017

Thank you @ogizanagi.

@fabpot fabpot merged commit 1417f11 into symfony:master Feb 16, 2017
fabpot added a commit that referenced this pull request Feb 16, 2017
…to use dashes (ogizanagi)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[DI][FrameworkBundle] ServiceLocator: fix XmlDescriptor to use dashes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21600 (comment)
| License       | MIT
| Doc PR        | N/A

As reported by @stof, I should have used dashes, not underscores. My bad...

Commits
-------

1417f11 [DI][FrameworkBundle] ServiceLocator: fix XML descriptor to use dashes
@ogizanagi ogizanagi deleted the fix/service_locator_xml_descr branch April 12, 2017 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants