[PropertyInfo] Use iterators for PropertyInfoExtractor #21654
Conversation
581088f to
fe09530
Compare
| * @param array $extractors | ||
| * @param string $method | ||
| * @param array $arguments | ||
| * @param array|\Traversable $extractors |
There was a problem hiding this comment.
can we use it in php docs?
There was a problem hiding this comment.
Yes, and we already did :)
|
👍 |
|
Actually, you need to add a conflict rule in FrameworkBundle, to forbid it to use an older property-info component (which would have an array typehint), if we don't have the conflict already |
fe09530 to
38523a9
Compare
|
Indeed, thanks! |
|
👍 |
|
Thank you @GuilhemN. |
… (GuilhemN) This PR was merged into the 3.3-dev branch. Discussion ---------- [PropertyInfo] Use iterators for PropertyInfoExtractor | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Most of the time, when using the cache, the property info extractors are not used: the new iterator feature looks perfect to prevent their instantiation. Commits ------- 38523a9 [PropertyInfo] Use iterators for PropertyInfoExtractor
| * @param PropertyTypeExtractorInterface[] $typeExtractors | ||
| * @param PropertyDescriptionExtractorInterface[] $descriptionExtractors | ||
| * @param PropertyAccessExtractorInterface[] $accessExtractors | ||
| * @param iterable|PropertyListExtractorInterface[] $listExtractors |
There was a problem hiding this comment.
iterable is not a valid keyword, even according to the (still) draft PSR-5. See phpDocumentor/fig-standards#141
But anyway I think it's redundant to write it like this, it should be simply iterable<PropertyListExtractorInterface>
There was a problem hiding this comment.
Nor is @final, its support will come when it will be adopted so imo it's not a problem.
About the redundancy I agree but we would lose all completion until editors add generics support, I don't think it's acceptable.
There was a problem hiding this comment.
Anyway, the RFC for introducing an iterable keyword has been accepted and PHP 7.1 supports this type: https://wiki.php.net/rfc/iterable
There was a problem hiding this comment.
@dunglas That's for PHP, not PHPDoc 😄
Most of the time, when using the cache, the property info extractors are not used: the new iterator feature looks perfect to prevent their instantiation.