Skip to content

[PropertyInfo] Make classes final #21655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions UPGRADE-3.3.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ DependencyInjection
* Using the `PhpDumper` with an uncompiled `ContainerBuilder` is deprecated and
will not be supported anymore in 4.0.

* Extending the containers generated by `PhpDumper` is deprecated and won't be
supported in 4.0.

* The `DefinitionDecorator` class is deprecated and will be removed in 4.0, use
the `ChildDefinition` class instead.

Expand All @@ -58,7 +61,7 @@ FrameworkBundle
* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\AddConsoleCommandPass` has been deprecated. Use `Symfony\Component\Console\DependencyInjection\AddConsoleCommandPass` instead.

* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\SerializerPass` class has been
deprecated and will be removed in 4.0.
deprecated and will be removed in 4.0.
Use the `Symfony\Component\Serializer\DependencyInjection\SerializerPass` class instead.

* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\FormPass` class has been
Expand All @@ -82,6 +85,9 @@ Process

* Configuring Windows and sigchild compatibility is deprecated - they will be always enabled in 4.0.

* Extending `Process::run()`, `Process::mustRun()` and `Process::restart()` is
deprecated and won't be supported in 4.0.

Security
--------

Expand All @@ -100,10 +106,16 @@ SecurityBundle
constructor arguments fully provided.
Registering by convention the command or commands extending it is deprecated and will
not be allowed anymore in 4.0.
* `UserPasswordEncoderCommand::getContainer()` is deprecated, and this class won't

* `UserPasswordEncoderCommand::getContainer()` is deprecated, and this class won't
extend `ContainerAwareCommand` nor implement `ContainerAwareInterface` anymore in 4.0.

Serializer
----------

* Extending `ChainDecoder`, `ChainEncoder`, `ArrayDenormalizer` is deprecated
and won't be supported in 4.0.

TwigBridge
----------

Expand Down
11 changes: 10 additions & 1 deletion UPGRADE-4.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ DependencyInjection
* Using the `PhpDumper` with an uncompiled `ContainerBuilder` is not supported
anymore.

* Extending the containers generated by `PhpDumper` is not supported
anymore.

* The `DefinitionDecorator` class has been removed. Use the `ChildDefinition`
class instead.

Expand Down Expand Up @@ -176,7 +179,7 @@ FrameworkBundle

* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\AddConsoleCommandPass` has been removed. Use `Symfony\Component\Console\DependencyInjection\AddConsoleCommandPass` instead.

* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\SerializerPass` class has been removed.
* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\SerializerPass` class has been removed.
Use the `Symfony\Component\Serializer\DependencyInjection\SerializerPass` class instead.

* The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\FormPass` class has been
Expand Down Expand Up @@ -242,6 +245,9 @@ Process

* Configuring Windows and sigchild compatibility is not possible anymore - they are always enabled.

* Extending `Process::run()`, `Process::mustRun()` and `Process::restart()` is
not supported anymore.

Security
--------

Expand All @@ -259,6 +265,9 @@ Serializer
`AbstractNormalizer::instantiateObject()` method when overriding it is not
supported anymore.

* Extending `ChainDecoder`, `ChainEncoder`, `ArrayDenormalizer` is not supported
anymore.

Translation
-----------

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
* Extracts data using a PHPDoc parser.
*
* @author Kévin Dunglas <dunglas@gmail.com>
*
* @final since version 3.3
*/
class PhpDocExtractor implements PropertyDescriptionExtractorInterface, PropertyTypeExtractorInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
* Extracts data using the reflection API.
*
* @author Kévin Dunglas <dunglas@gmail.com>
*
* @final since version 3.3
*/
class ReflectionExtractor implements PropertyListExtractorInterface, PropertyTypeExtractorInterface, PropertyAccessExtractorInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
* Lists available properties using Symfony Serializer Component metadata.
*
* @author Kévin Dunglas <dunglas@gmail.com>
*
* @final since version 3.3
*/
class SerializerExtractor implements PropertyListExtractorInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
* Adds a PSR-6 cache layer on top of an extractor.
*
* @author Kévin Dunglas <dunglas@gmail.com>
*
* @final since version 3.3
*/
class PropertyInfoCacheExtractor implements PropertyInfoExtractorInterface
{
Expand Down
2 changes: 2 additions & 0 deletions src/Symfony/Component/PropertyInfo/PropertyInfoExtractor.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
* Default {@see PropertyInfoExtractorInterface} implementation.
*
* @author Kévin Dunglas <dunglas@gmail.com>
*
* @final since version 3.3
*/
class PropertyInfoExtractor implements PropertyInfoExtractorInterface
{
Expand Down
2 changes: 2 additions & 0 deletions src/Symfony/Component/PropertyInfo/Type.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
* Type value object (immutable).
*
* @author Kévin Dunglas <dunglas@gmail.com>
*
* @final since version 3.3
*/
class Type
{
Expand Down