Updated PHPUnit namespaces #21663
Updated PHPUnit namespaces #21663
Conversation
|
|
||
| /** | ||
| * Collects and replays skipped tests. | ||
| * | ||
| * @author Nicolas Grekas <p@tchwork.com> | ||
| */ | ||
| class SymfonyTestsListener extends \PHPUnit_Framework_BaseTestListener | ||
| class SymfonyTestsListener extends BaseTestListener |
There was a problem hiding this comment.
I think the bridge should not be updated to namespaces - only on master we should do that
There was a problem hiding this comment.
How about requiring a proper PHPUnit version? Actually the issue will be that PHPUnit < 5.7 does have another FC layer than 4.8. If we go that route we should enforce 4.8.35, 5.7 or 6
There was a problem hiding this comment.
there is already a conflict rule, should be enough, isnt'it?
There was a problem hiding this comment.
Yes, but we need to make it stricter. With my attempt in #21668 we might be able to make the bridge compatible with 4.8.35, 5.7 and 6.* It would be great if you could have a look, some tweaks are still needed.
There was a problem hiding this comment.
What will using namespaces here provide at all on 2.8?
The bridge before 3.3 is still incompatible with phpunit 6 - using namespaces will only forbid its use with namespace-incompatible versions of phpunit.
#21668 is unrelated - it's only for master.
There was a problem hiding this comment.
Reverted as per your wish.
| @@ -12,6 +12,7 @@ | |||
| namespace Symfony\Bridge\PhpUnit; | |||
|
|
|||
| use Doctrine\Common\Annotations\AnnotationRegistry; | |||
| use PHPUnit\Framework\TestCase; | |||
There was a problem hiding this comment.
should be reverted for the same reasons as the previous
|
Updated |
|
Thank you @peterrehm. |
This PR was squashed before being merged into the 2.8 branch (closes #21663). Discussion ---------- Updated PHPUnit namespaces | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow Up of #21564 Commits ------- 205ced4 Updated PHPUnit namespaces
|
Same on 3.2 and master now? |
|
PR for 3.2 just provided. Once this is okay and merged I will look into master. |
This PR was merged into the 3.2 branch. Discussion ---------- Updated PHPUnit namespaces | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow Up of #21663 Commits ------- c2e80e3 Updated PHPUnit namespaces
|
One question @nicolas-grekas - When will this PR be merged and for which release is it planned? I saw that the 2.8.18 has been released today, so the next release will probably be in a month? Will this PR be also in the next release? Thanks! |
|
@tzfrs this is already released as part of 2.8.18 |
|
Ah, I misunderstood the release page then Because it doesn't say here that this PR is included. Also, this PR is just closed and not merged, so I assumed it hasn't been integrated yet. |
|
That's because it's labelled as a "minor" - thus not listed in the changelog. If you look just above your previous comment, you'll see this has bee merged as commit 13983d9 |
|
Ah okay thanks. However, I still get errors because of some code in the phpunit-bridge, but I saw you wrote here: #21694 (comment) that there is no plan of making 2.8 compatible with PhpUnit 6, right? So how would I use Symfony 2.8 with PhpUnit 6.0. Isn't it possible at this time and never will? |
|
@tzfrs It's just the PhpUnitBridge for which you need to require the latest versions ( |
|
Ah okay, thought I need it to have it at the same version as symfony. Ty. |
|
The bridge is a bit special here. By the way, we also use the latest version of the bridge to run tests for Symfony on all branches. And that does work. ;) |
Follow Up of #21564