[Yaml] fix DUMP_EMPTY_ARRAY_AS_SEQUENCE flag value #21678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Feb 20, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
GuilhemN
reviewed
Feb 20, 2017
| @@ -29,7 +29,7 @@ class Yaml | |||
| const DUMP_OBJECT_AS_MAP = 64; | |||
| const DUMP_MULTI_LINE_LITERAL_BLOCK = 128; | |||
| const PARSE_CONSTANT = 256; | |||
| const DUMP_EMPTY_ARRAY_AS_SEQUENCE = 512; | |||
| const DUMP_EMPTY_ARRAY_AS_SEQUENCE = 1024; | |||
There was a problem hiding this comment.
what about reversing DUMP_EMPTY_ARRAY_AS_SEQUENCE and PARSE_CUSTOM_TAGS values? It would look more natural imo.
There was a problem hiding this comment.
IMO it's not worth it. Otherwise we begin to swap values every time we introduce new flags.
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Feb 20, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- [Yaml] fix DUMP_EMPTY_ARRAY_AS_SEQUENCE flag value | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 3953d76 fix DUMP_EMPTY_ARRAY_AS_SEQUENCE flag value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.