[Security] deprecate multiple providers in context listener #21792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing multiple user providers to the context listener does not make much sense. The listener is only responsible to refresh users for a particular firewall. Thus, it must only be aware of the user provider for this particular firewall.
66f295b to
53df0de
Compare
|
This will need a rebase with #21791 being merged up to master. |
fabpot
reviewed
Feb 27, 2017
| { | ||
| if (empty($contextKey)) { | ||
| throw new \InvalidArgumentException('$contextKey must not be empty.'); | ||
| } | ||
|
|
||
| if (is_array($userProviders)) { | ||
| @trigger_error(sprintf('Being able to pass multiple user providers to the constructor of %s is deprecated since version 3.3 and will not be supported anymore in 4.0. Only pass the user provider for the current firewall context instead.', __CLASS__), E_USER_DEPRECATED); |
| @@ -94,6 +94,9 @@ Process | |||
| Security | |||
| -------- | |||
|
|
|||
| * Deprecated the ability to pass multiple user providers to the `ContextListener`. Pass only the user provider responsible | |||
| for the active firewall instead. | |||
There was a problem hiding this comment.
looks like it's not wrapped at 80 chars
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Feb 28, 2017
…tener (xabbuh) This PR was squashed before being merged into the 3.3-dev branch (closes #21792). Discussion ---------- [Security] deprecate multiple providers in context listener Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Passing multiple user providers to the context listener does not make much sense. The listener is only responsible to refresh users for a particular firewall. Thus, it must only be aware of the user provider for this particular firewall. Commits ------- 53df0de [Security] deprecate multiple providers in context listener fbd9f88 [SecurityBundle] only pass relevant user provider
|
@xabbuh a given firewall can rely on multiple user providers when multiple authentication listeners are enabled (as each of them can use a different user provider) |
This was referenced Feb 28, 2017
|
will be reverted by #21799 |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 28, 2017
…r provider (xabbuh)" (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- Revert "bug #21791 [SecurityBundle] only pass relevant user provider (xabbuh)" | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21791 | License | MIT | Doc PR | #21791 was a mistake as pointed out by @slaci (see #21791 (comment)) and @stof (see #21792 (comment)). Commits ------- f6637dd Revert "bug #21791 [SecurityBundle] only pass relevant user provider (xabbuh)"
nicolas-grekas
added a commit
that referenced
this pull request
Feb 28, 2017
…ders in context listener (xabbuh)" (xabbuh) This PR was merged into the 3.3-dev branch. Discussion ---------- Revert "feature #21792 [Security] deprecate multiple providers in context listener (xabbuh)" | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21791 | License | MIT | Doc PR | #21792 was a mistake as pointed out by @slaci (see #21791 (comment)) and @stof (see #21792 (comment)). Commits ------- 3cfa0c7 Revert "feature #21792 [Security] deprecate multiple providers in context listener (xabbuh)"
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing multiple user providers to the context listener does not make
much sense. The listener is only responsible to refresh users for a
particular firewall. Thus, it must only be aware of the user provider
for this particular firewall.