[DI] Simplify AutowirePass and other master-only cleanups #21797
Conversation
| if ($value instanceof ArgumentInterface) { | ||
| return $this->describeValue($value->getValues(), $omitTags, $showArguments); | ||
| } | ||
|
|
||
| if ($value instanceof Definition) { |
There was a problem hiding this comment.
changing the order here is because of the needs of #21708, right ? IMO, this is a clear sign that your other PR breaks BC (other bundles may have similar code)
There was a problem hiding this comment.
there is no BC issue: ArgumentInterface is a new feature of master
There was a problem hiding this comment.
but existing code might check for Definition. And in your PRs, you have ServiceLocatorArgument extending Definition but which should not be processed like a Definition.
There was a problem hiding this comment.
The existing code won't get a new ServiceLocatorArgument all of a sudden, so if they do, someone did write some new code - thus we're out of BC concerns.
Processing ServiceLocatorArgument as a Definition wouldn't be a big issue btw. Existing code won't get the added semantic, but they will not break. Note that this is also true for pure ArgumentInterface instances also.
There was a problem hiding this comment.
@nicolas-grekas existing bundles may have compiler passes processing the container. And Symfony 3.3 will change some existing services to use such argument.
Pure ArgumentInterface would be an argument for which they cannot do special processing. A Definition which must not be processed like a Definition is much worse, as they will think they can process it.
|
Thank you @nicolas-grekas. |
…(nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Simplify AutowirePass and other master-only cleanups | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - A few minor cleanups and fixes, and an overall simplification of AutowirePass. Commits ------- 34e5cc7 [DI] Simplify AutowirePass and other master-only cleanups
A few minor cleanups and fixes, and an overall simplification of AutowirePass.