#21809 [SecurityBundle] bugfix: if security provider's name contains upper cases then container didn't compile #21810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any test case? |
|
still no, in 20min |
|
@antanas-arvasevicius Can you confirm that this change is not necessary if #21811 gets merged? |
0329b73 to
7625f9e
Compare
|
added test cases for this. I think it's better to accept this PR as this will prevent that kind of bugs in the future. |
…ntains upper cases then container didn't compile
7625f9e to
e0107d0
Compare
|
test errors on 5.5 7.1 https://travis-ci.org/symfony/symfony/jobs/206617501#L2417 |
fabpot
added a commit
that referenced
this pull request
Mar 1, 2017
… (xabbuh) This PR was merged into the 3.3-dev branch. Discussion ---------- Revert "[SecurityBundle] only pass relevant user provider" | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21809, #21810 | License | MIT | Doc PR | This reverts commit d97e07f (applies #21798 on `master`). There is no merge commit that could be reverted. Commits ------- 5b016ce Revert "[SecurityBundle] only pass relevant user provider"
|
@antanas-arvasevicius Indeed, just removing the |
|
Thank you @antanas-arvasevicius. |
fabpot
added a commit
that referenced
this pull request
Mar 23, 2017
…e contains upper cases then container didn't compile (Antanas Arvasevicius) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #21810). Discussion ---------- #21809 [SecurityBundle] bugfix: if security provider's name contains upper cases then container didn't compile | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? no | Tests pass? | yes | Fixed tickets | #21809 | License | MIT then security.yml providers was with upper case, on container compile error was thrown: ```` [04:39:32][Ant output] [exec] [exec] > Sensio\Bundle\DistributionBundle\Composer\ScriptHandler::clearCache [04:39:32][Ant output] [exec] [exec] [04:39:32][Ant output] [exec] [exec] [04:39:32][Ant output] [exec] [exec] [Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException] [04:39:32][Ant output] [exec] [exec] The service "security.authentication.provider.simple_form.default" has a de [04:39:32][Ant output] [exec] [exec] pendency on a non-existent service "security.user.provider.concrete.carrier [04:39:32][Ant output] [exec] [exec] User". ````` Problem has occurred with this commit line: fbd9f88#diff-2be909961a57bf75fbb600c1f5fc46e3R320 Issue fixes with this PR. Commits ------- 6d23c8c #21809 [SecurityBundle] bugfix: if security provider's name contains upper cases then container didn't compile
|
@fabpot, if |
|
@antanas-arvasevicius I've taken care of it when merging. Thanks. |
This was referenced Apr 4, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
then security.yml providers was with upper case, on container compile error was thrown:
Problem has occurred with this commit line:
fbd9f88#diff-2be909961a57bf75fbb600c1f5fc46e3R320
Issue fixes with this PR.