Skip to content

[FrameworkBundle][HttpKernel] Move ControllerArgumentValueResolverPass to the HttpKernel component #21815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2017
Merged

[FrameworkBundle][HttpKernel] Move ControllerArgumentValueResolverPass to the HttpKernel component #21815

merged 1 commit into from
Mar 4, 2017

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Mar 1, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@chalasr chalasr force-pushed the argvalresolverpass branch from cd3e3d8 to 30bc005 Compare March 1, 2017 17:20
@chalasr
Copy link
Member Author

chalasr commented Mar 1, 2017

different failures are all unrelated, this is ready.

@chalasr chalasr force-pushed the argvalresolverpass branch 5 times, most recently from bcfd2d5 to 7497d45 Compare March 3, 2017 09:29
@chalasr chalasr force-pushed the argvalresolverpass branch from 7497d45 to 8bad8a1 Compare March 3, 2017 12:55
@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Mar 4, 2017
nicolas-grekas
nicolas-grekas approved these changes Mar 4, 2017
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fabpot
Copy link
Member

fabpot commented Mar 4, 2017

Thank you @chalasr.

@fabpot fabpot merged commit 8bad8a1 into symfony:master Mar 4, 2017
fabpot added a commit that referenced this pull request Mar 4, 2017
@fabpot
feature #21815 [FrameworkBundle][HttpKernel] Move ControllerArgumentV…
b118c65 
…alueResolverPass to the HttpKernel component (chalasr)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[FrameworkBundle][HttpKernel] Move ControllerArgumentValueResolverPass to the HttpKernel component

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

8bad8a1 Move ControllerArgumentValueResolverPass to the HttpKernel component
@chalasr chalasr deleted the argvalresolverpass branch March 4, 2017 18:30
@chalasr chalasr mentioned this pull request Mar 6, 2017
Closed
11 tasks
@fabpot fabpot mentioned this pull request May 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

Assignees
No one assigned
Labels
Deprecation Feature FrameworkBundle HttpKernel Status: Needs Review
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@chalasr @fabpot @nicolas-grekas @ogizanagi @carsonbot