Skip to content

Fix broken AddConstraintValidatorsPassTest #21821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2017
Merged

Fix broken AddConstraintValidatorsPassTest #21821

merged 1 commit into from
Mar 1, 2017

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Mar 1, 2017 •
edited
Loading

@chalasr chalasr mentioned this pull request Mar 1, 2017
Closed
GuilhemN
GuilhemN approved these changes Mar 1, 2017
View reviewed changes
Copy link
Contributor

@GuilhemN GuilhemN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, made that change too quickly 😅

@fabpot
Copy link
Member

fabpot commented Mar 1, 2017

Good catch, thanks @chalasr.

@fabpot fabpot merged commit 8ba1412 into symfony:master Mar 1, 2017
fabpot added a commit that referenced this pull request Mar 1, 2017
@fabpot
minor #21821 Fix broken AddConstraintValidatorsPassTest (chalasr)
e1c28de 
This PR was merged into the 3.3-dev branch.

Discussion
----------

Fix broken AddConstraintValidatorsPassTest

| Q             | A
| ------------- | ---
| Branch?       | master
| Fixed tickets | https://github.com/symfony/symfony/pull/21730/files#r103740309

Commits
-------

8ba1412 Fix broken AddConstraintValidatorsPassTest
@chalasr chalasr deleted the framework-fix-test branch March 1, 2017 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuilhemN GuilhemN GuilhemN approved these changes

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @fabpot @GuilhemN @carsonbot