[PhpUnitBridge] include expected deprecations in assertion counter #21828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 2, 2017
…tion counter (xabbuh) This PR was merged into the 3.3-dev branch. Discussion ---------- [PhpUnitBridge] include expected deprecations in assertion counter | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21786 (comment) | License | MIT | Doc PR | We still need to include the changes from #21786 as we cannot increment the number of assertions in the `startTest()` method (the PHPUnit test runner resets the counter after the listeners have been executed). Commits ------- cdcd5ae include expected deprecations in assertion counter
|
I think the issue is that |
|
My conclusion is that PHPUnit simply does not expect listeners to be a place performing assertions |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still need to include the changes from #21786 as we cannot increment the number of assertions in the
startTest()method (the PHPUnit test runner resets the counter after the listeners have been executed).