[FrameworkBundle][Routing] Move RoutingResolverPass to the Routing component #21835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Mar 2, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
b63bbeb to
7135861
Compare
| use Symfony\Component\DependencyInjection\Reference; | ||
| use Symfony\Component\DependencyInjection\ContainerBuilder; | ||
| use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface; | ||
| @trigger_error(sprintf('The %s class is deprecated since version 3.3 and will be removed in 4.0. Use Symfony\Component\Routing\DependencyInjection\RoutingResolverPass instead.', RoutingResolverPass::class), E_USER_DEPRECATED); |
There was a problem hiding this comment.
you can move that line below the "use" and use BaseRoutingResolverPass::class in sprintf
There was a problem hiding this comment.
Ok I wasn't sure if having it immediately after the namespace has an importance
| @@ -23,6 +23,7 @@ | |||
| "symfony/http-foundation": "~2.8|~3.0", | |||
| "symfony/yaml": "~2.8|~3.0", | |||
| "symfony/expression-language": "~2.8|~3.0", | |||
| "symfony/dependency-injection": "~2.7|~3.0", | |||
7135861 to
7d062fb
Compare
7f9ce37 to
8b04332
Compare
| class RoutingResolverPass implements CompilerPassInterface | ||
| { | ||
| private $resolverServiceId = 'routing.resolver'; | ||
| private $loaderTag = 'routing.loader'; |
There was a problem hiding this comment.
default values could be removed here, would prevent a duplication and any sync mistake
There was a problem hiding this comment.
that's a mistake, fixed. Thanks
8b04332 to
32be16b
Compare
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Mar 5, 2017
… the Routing component (chalasr) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle][Routing] Move RoutingResolverPass to the Routing component | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 32be16b Move RoutingResolverPass to the Routing component
11 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.