[HttpFoundation] Fix Request::getHost() when having several hosts in X_FORWARDED_HOST #21846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Mar 3, 2017
|
|
||
| $host = $elements[count($elements) - 1]; | ||
| $host = $elements[0]; |
There was a problem hiding this comment.
That's suspicious to me. Why do you think this is a bug?
There was a problem hiding this comment.
Because the port and scheme info are taken from the other edge, so this looks even more suspicious to me :) if the goal is to give back the user facing host, this is currently the wrong side.
I'd be happy to have eg @stof give his PV here.
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Mar 22, 2017
…l hosts in X_FORWARDED_HOST (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [HttpFoundation] Fix Request::getHost() when having several hosts in X_FORWARDED_HOST | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The first "host" in the list provided by `X_FORWARDED_HOST` should be the one, not the last. Already the case for "port" and "scheme". Commits ------- 9a2b2de [HttpFoundation] Fix Request::getHost() when having several hosts in X_FORWARDED_HOST
This was referenced Apr 4, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first "host" in the list provided by
X_FORWARDED_HOSTshould be the one, not the last.Already the case for "port" and "scheme".