[Console] Optionally stop options parsing at "--", fixes #21869 #21870
Conversation
Looking for options in the (raw) arguments should not look after an argument of "--" has been encountered. Not doing so prevents invoking the command or passing these arguments to the command w/o interfering with the wrong application or command. Places where the application looks for global flags like --verbose or --help make use of the new OPTION_FLAG_POSIX that stops parsing options at the options-from-operands delimiter "--" as in 12.2 Utility Syntax Guidelines Guideline 10. Refs: - http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap12.html#tag_12_02
|
|
|
Hmm, I see
So if the fix is only in 3.0, then this has been filed against the wrong branch according to the docs I read yesterday, it's written, that it needs to go against the lowest supported one. Can't the fix be ported onto 2.7+? |
|
Looks like the fix is done in a similar fashion. A pity I have not seen it earlier, it's some time ago. |
|
This can be seen as a bug fix, but this is also a behavior change, so back then, we decided to merge it in master. We won't change the decision, so it cannot be backported. |
|
Hmm, the behaviour of the routine does not change. What actually changes, is the flaw removed. I don't think there is much to decide, but it's your decision, I don't want anyone to loose her or his face, I mean that was back in 2014 considering now that as a bug is indeed a bit late. |
|
Closing then. Thanks. |
Looking for options in the (raw) arguments should not look after an
argument of "--" has been encountered.
Not doing so prevents invoking the command or passing these arguments to
the command w/o interfering with the wrong application or command.
With this change: Places where the application looks for global flags like --verbose or
--help make use of the new OPTION_FLAG_POSIX that stops parsing options
at the options-from-operands delimiter "--" as in 12.2 Utility Syntax
Guidelines Guideline 10.
Refs: