[Form] Fixed overridden choices option in extended choice types #21880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeahDude
commented
Mar 5, 2017
| Q | A |
|---|---|
| Branch? | 3.2 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20771 |
| License | MIT |
| Doc PR | ~ |
| use Symfony\Component\Form\Forms; | ||
| use Symfony\Component\Form\Tests\Fixtures\ChoiceTypeExtension; | ||
|
|
||
| class ExtendedChoiceTypeTest extends \PHPUnit_Framework_TestCase |
There was a problem hiding this comment.
legacy TestCase, should use namespaced version
There was a problem hiding this comment.
This is not a legacy test :). At least for now.
There was a problem hiding this comment.
the "underscore" is legacy in PHPUnit_Framework_TestCase, not the test case :)
xabbuh
approved these changes
Mar 6, 2017
c71fd5f to
bcda2c2
Compare
|
Rebased, ready to merge! |
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Mar 6, 2017
…types (HeahDude) This PR was merged into the 3.2 branch. Discussion ---------- [Form] Fixed overridden choices option in extended choice types | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20771 | License | MIT | Doc PR | ~ Commits ------- bcda2c2 [Form] Fixed overridden choices option in extended choice types
Merged
fabpot
added a commit
that referenced
this pull request
Apr 5, 2017
…es (HeahDude) This PR was merged into the 3.3-dev branch. Discussion ---------- [Form] Deprecated usage of "choices" option in sub types | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | ~ Follows #21880 and the discussion in #20771. Commits ------- b5b56fc [Form] Deprecated usage of "choices" option in sub types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.