Skip to content

[HttpKernel] fix Kernel name when stored in a directory starting with a number #21883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2017
Merged

[HttpKernel] fix Kernel name when stored in a directory starting with a number #21883

merged 1 commit into from
Mar 6, 2017

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Mar 5, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20489
License MIT
Doc PR -

replaces #20750

@fabpot fabpot mentioned this pull request Mar 5, 2017
Closed
javiereguiluz
javiereguiluz approved these changes Mar 6, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Mar 6, 2017
nicolas-grekas
nicolas-grekas approved these changes Mar 6, 2017
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

stof
stof approved these changes Mar 6, 2017
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

xabbuh
xabbuh approved these changes Mar 6, 2017
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lyrixx
Copy link
Member

lyrixx commented Mar 6, 2017

replace also #13412 (comment)

anyway 👍

@fabpot fabpot merged commit f244eb8 into symfony:2.7 Mar 6, 2017
fabpot added a commit that referenced this pull request Mar 6, 2017
@fabpot
bug #21883 [HttpKernel] fix Kernel name when stored in a directory st…
ec134c7 
…arting with a number (fabpot)

This PR was merged into the 2.7 branch.

Discussion
----------

[HttpKernel] fix Kernel name when stored in a directory starting with a number

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20489
| License       | MIT
| Doc PR        | -

replaces #20750

Commits
-------

f244eb8 [HttpKernel] fixed Kernel name when stored in a directory starting with a number
@fabpot fabpot mentioned this pull request Mar 9, 2017
Merged
This was referenced Apr 4, 2017
Merged
Merged
@fabpot fabpot deleted the kernel-starting-with-a-number branch April 7, 2017 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
7 participants
@fabpot @lyrixx @javiereguiluz @nicolas-grekas @stof @xabbuh @carsonbot