[Workflow] Delete dead code #21913
Merged
[Workflow] Delete dead code #21913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technically, it's a non-internal class available eg on v3.2.4, removing it is BC breaker :/ |
|
👍 Not used and not documented. |
7eecd30 to
28e85cc
Compare
nicolas-grekas
approved these changes
Mar 8, 2017
lyrixx
added a commit
that referenced
this pull request
Mar 8, 2017
This PR was merged into the 3.2 branch. Discussion ---------- [Workflow] Delete dead code | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | "no" | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - --- Me (and all reviewers ;) ) totally miss this class. It has never been used and there are no reason to use it anyway. It's just a relic from the designing of the Component. Sorry. I really don't think it deserves a deprecation as the component is quite new, and it is really some dead code. Commits ------- 28e85cc [Workflow] Delete dead code
|
👍 for this too. It is not used, and it was never used (usage was removed before merging the PR). So there is no reason for external code to depend on it, assuming they discovered it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me (and all reviewers ;) ) totally miss this class. It has never been used and there are no reason to use it anyway. It's just a relic from the designing of the Component. Sorry.
I really don't think it deserves a deprecation as the component is quite new, and it is really some dead code.