Skip to content

[Cache] Cached files rely on umask #21930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2017
Merged

[Cache] Cached files rely on umask #21930

merged 1 commit into from
Mar 9, 2017

Conversation

4rthem
Copy link
Contributor

@4rthem 4rthem commented Mar 8, 2017

Q A
Branch? 3.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #21929
License MIT
Doc PR

nicolas-grekas
nicolas-grekas approved these changes Mar 8, 2017
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

javiereguiluz
javiereguiluz approved these changes Mar 8, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@4rthem thanks for reporting this issue in the first place and then for providing a solution for it!

xabbuh
xabbuh approved these changes Mar 8, 2017
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fabpot
Copy link
Member

fabpot commented Mar 9, 2017

Thank you @4rthem.

@fabpot fabpot merged commit 865a6af into symfony:3.2 Mar 9, 2017
fabpot added a commit that referenced this pull request Mar 9, 2017
@fabpot
bug #21930 [Cache] Cached files rely on umask (4rthem)
063c8c3 
This PR was merged into the 3.2 branch.

Discussion
----------

[Cache] Cached files rely on umask

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21929
| License       | MIT
| Doc PR        |

Commits
-------

865a6af cached files rely on umask
@4rthem 4rthem deleted the fix-cache-mod branch March 9, 2017 23:59
@fabpot fabpot mentioned this pull request Mar 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Cache Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@4rthem @fabpot @javiereguiluz @nicolas-grekas @xabbuh @chalasr @carsonbot