[FrameworkBundle][Workflow] Add a way to enable the AuditTrail Logger #21933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afa96d7 to
633c039
Compare
| @@ -480,13 +479,24 @@ private function registerWorkflowConfiguration(array $workflows, ContainerBuilde | |||
| // Add workflow to Registry | |||
| if ($workflow['supports']) { | |||
| foreach ($workflow['supports'] as $supportedClassName) { | |||
| $strategyDefinition = new Definition(ClassInstanceSupportStrategy::class, array($supportedClassName)); | |||
| $strategyDefinition = new Definition(Workflow\SupportStrategy\ClassInstanceSupportStrategy::class, array($supportedClassName)); | |||
There was a problem hiding this comment.
To reduce the number of use statement and to be consistant with other "...\Workflow" usage.
|
|
||
| // Enable the AuditTrail | ||
| if ($workflow['audit_trail']['enabled']) { | ||
| $listener = new Definition(Workflow\EventListener\AuditTrailListener::class); |
There was a problem hiding this comment.
use a use statement instead? more "SF style" to me
There was a problem hiding this comment.
Right now, there are more usage of "this style" than FQCN
There was a problem hiding this comment.
Just saw that, in the Workflow namespace in fact. OK then.
josephdpurcell
pushed a commit
to josephdpurcell/symfony
that referenced
this pull request
Mar 10, 2017
… the AuditTrail Logger (lyrixx) This PR was squashed before being merged into the 3.3-dev branch (closes symfony#21933). Discussion ---------- [FrameworkBundle][Workflow] Add a way to enable the AuditTrail Logger | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - --- This will increase the visibility of the Listener. We could encourage people to use at least `%kernel.debug%` value. --- Note for the merge: There are two commits, this is done on purpose (2 different things, but easier to do only one PR) Commits ------- 633c039 [Workflow] Added the workflow name in log generated by AuditTrailListener b786bcc [FrameworkBundle][Workflow] Add a way to enable the AuditTrail Logger
lyrixx
added a commit
that referenced
this pull request
Apr 5, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- [Workflow] sync the changelog | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20751, #21334, #21933, #21935, #21950 | License | MIT | Doc PR | Commits ------- 98a18ee [Workflow] sync the changelog
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will increase the visibility of the Listener. We could encourage people to use at least
%kernel.debug%value.Note for the merge: There are two commits, this is done on purpose (2 different things, but easier to do only one PR)