[DependencyInjection] Support anonymous services in Yaml #21970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ba0c74 to
bec639f
Compare
c4f6dea to
7a00fdb
Compare
nicolas-grekas
approved these changes
Mar 14, 2017
|
|
||
| throw new InvalidArgumentException(sprintf('Unsupported tag "!%s".', $value->getTag())); | ||
| } | ||
|
|
||
| if (is_array($value)) { | ||
| $value = array_map(array($this, 'resolveServices'), $value); | ||
| foreach ($value as &$v) { |
There was a problem hiding this comment.
would be better to get rid of the reference to me
| @@ -696,12 +701,39 @@ private function resolveServices($value) | |||
|
|
|||
| return new ClosureProxyArgument($argument[0], $argument[1], $invalidBehavior); | |||
| } | |||
| // Anonymous service | |||
There was a problem hiding this comment.
not sure this comment provides anything
Thinking a bit more about this, my opinion on it is that it's a bug that should be fixed in XmlFileLoader also. |
|
good to merge as is to me, my previous comments are for another PR |
|
Thank you @GuilhemN. |
fabpot
added a commit
that referenced
this pull request
Mar 14, 2017
…ml (GuilhemN) This PR was merged into the 3.3-dev branch. Discussion ---------- [DependencyInjection] Support anonymous services in Yaml | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #16328 | License | MIT | Doc PR | This PR allows creating anonymous services in yaml using the `!service` tag as proposed by @nicolas-grekas: ```yml services: _instanceof: FooInterface: arguments: - !service class: Bar autowire: true Foo: factory: [ !service { class: Quz }, 'constructFoo' ] ``` Anonymous services are forbidden in parameters as in xml. Defaults and instanceof conditionals aren't applied on anonymous services, as in xml too. Commits ------- 9b71385 [DependencyInjection] Support anonymous services in Yaml
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows creating anonymous services in yaml using the
!servicetag as proposed by @nicolas-grekas:Anonymous services are forbidden in parameters as in xml.
Defaults and instanceof conditionals aren't applied on anonymous services, as in xml too.